Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOARD: Add IPK package manager after firstboot #133

Merged
merged 2 commits into from
Nov 9, 2024
Merged

BOARD: Add IPK package manager after firstboot #133

merged 2 commits into from
Nov 9, 2024

Conversation

tiopex
Copy link
Contributor

@tiopex tiopex commented Oct 29, 2024 •
edited
Loading

  • Add IPK package manager after firstboot
  • switch term to linux to enable colors in dialogs

@Apaczer
Copy link
Member

Apaczer commented Oct 29, 2024

ah tks much better with linux term. Don't trust busybox's bash to much (it comes with "surprises"), I try to stick to POSIX shell when possible.

@tiopex tiopex force-pushed the ipk-dialog branch 2 times, most recently from 90d7705 to 6ece0c1 Compare October 30, 2024 08:36
@tiopex tiopex marked this pull request as ready for review October 30, 2024 09:17
Apaczer
Apaczer requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Apaczer Apaczer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works goods 👍, I would include ipk_install.sh in gmenu2x apps section for bulk install (until I add smth in frontends code), but not sure if we can bypass > /dev/null redirect.

board/miyoo/boot/firstboot Outdated Show resolved Hide resolved
board/miyoo/boot/ipk_install.sh Outdated Show resolved Hide resolved
board/miyoo/boot/ipk_install.sh Outdated Show resolved Hide resolved
Apaczer
Apaczer approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@Apaczer Apaczer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 , LGTM futher we should simply mv all ipks to one place (see MiyooCFW/apps) and just grab from ther with one tarball (or from master)

@tiopex tiopex merged commit 6f3f361 into MiyooCFW:master Nov 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apaczer Apaczer Apaczer approved these changes

@TriForceX TriForceX Awaiting requested review from TriForceX

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiopex @Apaczer