Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor/#444] lottie 라이브러리 변경 및 build chunks 분리 #445

Merged
merged 9 commits into from
Oct 29, 2024

Conversation

moondda
Copy link
Contributor

@moondda moondda commented Oct 10, 2024

✨ 해당 이슈 번호 ✨

closed #444

todo

  • 로티 라이브러리 변경
  • 빌드 warning 해결

📌 내가 알게 된 부분

📌 질문할 부분

  • 별거는 아닌데 라이브러리 변경하면서 발생한 일들이랑 해결 과정 짜미들의 트러블슛에 공유했습니다 궁금하시면 봐주세용!
  • 저번에 빌드하고 성능을 체크해야할지 안하고 체크하는지에 대해 잠깐 얘기했었는데 궁금해서 좀 찾아봤습니다. 노션 맨 밑쪽에 번외로 적어뒀슴다~
  • 번들러 관리도 나름 재밋네용

📌스크린샷(선택)

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mile-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 8:05am

@github-actions github-actions bot added the size/s size/s label Oct 10, 2024
@moondda moondda self-assigned this Oct 10, 2024
@moondda moondda added ⚒️ Fix 기존의 버그 수정 다현 ♻️ Refactor 코드 리팩토링 and removed ⚒️ Fix 기존의 버그 수정 labels Oct 10, 2024
@moondda moondda changed the title [Refactor/#444] lottie 라이브러리 변경 [Refactor/#444] lottie 라이브러리 변경 및 build chunks 분리 Oct 13, 2024
Copy link
Contributor

@se0jinYoon se0jinYoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
아티클 읽고 많이 배워가요 든든국밥 개발자양

import Lottie from 'lottie-react';

import * as lottie from 'lottie-web/build/player/lottie_light';
type LettiePlayer = typeof lottie.default;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p5) lottie

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

역시 영문과

Copy link
Member

@ljh0608 ljh0608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

새로운 지식을 많이 배워갑니다! 여기에 더해서 계속 성능개선점에 대한 이야기를 같이 나눠보면 좋을 것 같아요~

@moondda moondda merged commit 496e438 into develop Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ Refactor 코드 리팩토링 size/s size/s 다현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Refactor ] 로티 번들사이즈 줄이기
3 participants