-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: detect incoming transactions using accounts API #4927
Draft
matthewwalsh0
wants to merge
18
commits into
main
Choose a base branch
from
feat/incoming-transactions-accounts-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support pagination. Support transaction limit.
Rename last fetched state. Add logging to wipe transactions. Refactor remote transaction source.
Always update last fetched timestamps. Remove block tracker references in unit tests.
Move cache logic into remote transaction source. Support queryEntireHistory property. Support updateTransactions property. Support includeTokenTransfers property. Ignore duplicate incoming transactions.
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Poll for incoming transactions using the accounts API rather than Etherscan.
Specifically:
PollingBlockTracker
.etherscan
util andEtherscanRemoteTransactionSource
.accounts-api
util andAccountsApiRemoteTransactionSource
.ETHERSCAN_SUPPORTED_NETWORKS
constant.IncomingTransactionHelper
.IncomingTransactionHelper
instance creation fromMultichainTrackingHelper
.lastFetchedBlockNumbers
when callingwipeTransactions
.RemoteTransactionSource
viagetCache
andupdateCache
properties.References
Changelog
See
CHANGELOG.md
.Checklist