Unnecessary state update when the balance did not change at account t…

…racker controller polling mechanism, which was causing unnecessary re renders
MetaMask · Oct 22, 2024 · c970faf · c970faf
1 parent 54ddebf
commit c970faf
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/packages/assets-controllers/src/AccountTrackerController.ts b/packages/assets-controllers/src/AccountTrackerController.ts
@@ -343,21 +343,24 @@ export class AccountTrackerController extends StaticIntervalPollingController<
         : [toChecksumHexAddress(selectedAccount.address)];
 
       const accountsForChain = { ...accountsByChainId[chainId] };
+      let balanceChanged = false;
       for (const address of accountsToUpdate) {
         const balance = await this.#getBalanceFromChain(address, ethQuery);
-        if (balance) {
+        if (balance && accountsForChain[address]?.balance !== balance) {
           accountsForChain[address] = {
             balance,
           };
+          balanceChanged = true;
         }
       }
-
-      this.update((state) => {
-        if (chainId === this.#getCurrentChainId()) {
-          state.accounts = accountsForChain;
-        }
-        state.accountsByChainId[chainId] = accountsForChain;
-      });
+      if (balanceChanged) {
+        this.update((state) => {
+          if (chainId === this.#getCurrentChainId()) {
+            state.accounts = accountsForChain;
+          }
+          state.accountsByChainId[chainId] = accountsForChain;
+        });
+      }
     } finally {
       releaseLock();
     }