-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django Ninja templates #782
base: develop
Are you sure you want to change the base?
Conversation
…ase with django-fastapi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the problem is not caused by this PR but there's a typo in this file:
init_listner
should be init_listener
. Would it be possible to fix it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same typo here:
init_listner
-> init_listener
@@ -0,0 +1,35 @@ | |||
ARG MNP_UI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there's a reason for the renaming but without any context on that my preference would be to keep the more generic name: CLOUDHARNESS_FRONTEND_BUILD instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "__APP_NAME__.settings")
should actually be:
os.environ.setdefault("DJANGO_SETTINGS_MODULE", "django_baseapp.settings")
since that's the place where the settings are defined
@@ -0,0 +1,2 @@ | |||
pydantic==2.9.2 | |||
django-ninja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to have cloudharness and cloudharness_django as dependencies here? Since they are conceptually required to run the application (f.e. they are used in settings.py) cc @ddelpiano
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect so. I understand we might need CH repo locally if I am in need of regen the template files or the codefresh pipeline, but if I am purely working on the backend I might not need CH and such dependency should be part of the requirements.txt so that all I need to run the backend is already covered by that. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's better to be explicit about all the dependencies that are imported, even if they are inherited by the base image (like this case)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requirements.txt is missing ch as dependency since the settings.py of the template requires it.
Closes CH-157
Added support for a django-ninja template when using harness-application and harness-generate. Also refactored the application build process into a more structured process of builder components.
...
To test try generating applications using
harness-application -t django-ninja
and also usingharness-generate servers
for that app to see the generates servers and openapi schema....
Sanity checks:
Breaking changes (select one):
breaking-change
and the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deployment
Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):