-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CH-151 Application generation improvements #778
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stapi-codegen rather than genapi.sh
… upcoming changes
…r more flexibility of options
condar-metacell
added
enhancement
New feature or request
python
Pull requests that update Python code
scope:code-generation
maintainance
labels
Oct 8, 2024
filippomc
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alert:python-code
breaking change
enhancement
New feature or request
maintainance
python
Pull requests that update Python code
refactoring
scope:code-generation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CH-151
Significant refactoring of both
harness-application
andharness-generate
plus added the features listed in the ticket as well as:--app-name/-a
option to allharness-generate
calls which restricts clients and servers to only generate for the specified app.ch-manifest
file inharness-application
to help simplify the logic inharness-generate
harness-generate
by using sub-parser commandsharness-generate
Breaking Changes
This is a breaking change to the command line interface of
harness-generate
, the following are the changes that will need to be accounted for:harness-generate
command now has 4 sub-commands:all
,clients
,models
andservers
which will run the generation script for all resource types, client code, models and server stubs respectfully.harness-generate
which generated all types of resources is no longer valid, instead useharness-generate all
-c/--clients
has been removed, instead useharness-generate clients
-m/--models
has been removed, instead useharness-generate models
-s/--server
command line option has been removed and it's responsibilities split:harness-generate servers
-a/--app-name
-a/--app-name
option; client and server generation is restricted to the app selected....
Use both
harness-application
andharness-generate
to create apps, stubs and clients.harness-deployment
andskaffold
should work from a newly created app without any additional steps needed....
Sanity checks:
Breaking changes (select one):
breaking-change
and the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deployment
Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):