CH-145 Add spec.ingressClassName to ingress template #769
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes CH-145
Added
spec.ingressClassName
to the ingress template, left thekubernetes.io/ingress.class
annotation as it is still required by Google Kubernetes Engine that we deploy to....
Deploy to a local Kubernetes cluster, there should be no functional change but the warning about deprecated annotation should no longer be present.
...
Sanity checks:
Breaking changes (select one):
breaking-change
and the migration procedure is well described abovePossible deployment updates issues (select one):
alert:deployment
Test coverage (select one):
Documentation (select one):
Nice to have (if relevant):