Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve api tests #704

Merged
merged 8 commits into from
Aug 24, 2023
Merged

Fix and improve api tests #704

merged 8 commits into from
Aug 24, 2023

Conversation

filippomc
Copy link
Collaborator

@filippomc filippomc commented Aug 23, 2023

Closes #700
Closes #703

Implemented solution: Added alternative path as django-based applications use /openapi.json instead of /api/openapi.json as schema url.
Also added alternative local schema file for schema tweaks for local tests developments

How to test this PR: run harness-test against a deployment including a django application

Sanity checks:

  • The pull request is explicitly linked to the relevant issue(s)
  • The issue is well described: clearly states the problem and the general proposed solution(s)
  • From the issue and the current PR it is explicitly stated how to test the current change
  • The labels in the issue set the scope and the type of issue (bug, feature, etc.)
  • All the automated test checks are passing
  • All the linked issues are included in one milestone
  • All the linked issues are in the Review/QA column of the board
  • All the linked issues are assigned

Breaking changes (select one):

  • The present changes do not change the preexisting api in any way
  • This PR and the issue are tagged as a breaking-change

Possible deployment updates issues (select one):

  • There is no reason why deployments based on CloudHarness may break after the current update
  • This PR and the issue are tagged as alert:deployment

Test coverage (select one):

  • Tests for the relevant cases are included in this pr
  • The changes included in this pr are out of the current test coverage scope

Documentation (select one):

  • The documentation has been updated to match the current changes
  • The changes included in this PR are out of the current documentation scope

Nice to have (if relevant):

  • Screenshots of the changes
  • Explanatory video/animated gif

@filippomc filippomc merged commit 36791b2 into develop Aug 24, 2023
5 checks passed
@filippomc filippomc deleted the feature/700 branch August 24, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API tests use local openapi file with harness-test API tests not working for django based backend
2 participants