fix clippy warnings #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh wait, #43 still needs to be fixed. I'll look into that at some point in the near future. |
uklotzde
approved these changes
Jan 7, 2024
core/src/read/read_stream.rs
Outdated
| ReadServerOptions { | ||
| file, | ||
| start_frame, | ||
| num_prefetch_blocks: stream_opts.num_cache_blocks |
There was a problem hiding this comment.
stream_opts should be destructured instead of accessing all fields individually. This ensures that you don't miss any field. Also applies to other parts of the code.
Should be improved by a follow-up PR.
There was a problem hiding this comment.
What do you mean by "destructured"?
orottier
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed all the clippy warnings, and also added missing panic documentation.
I think the code is now at a place where I'm fairly happy with it (well at least the stuff that doesn't require a breaking change to the API).