Ignore Content-Type header when certificate of type PEM is detected
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 85.66% 85.66% -0.01%
==========================================
Files 50 50
Lines 5212 5211 -1
==========================================
- Hits 4465 4464 -1
Misses 747 747
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
MatthiasValvekens
approved these changes
Sep 17, 2023
| @@ -68,17 +68,6 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| ACCEPTABLE_PKCS7_PEM_ALIASES = frozenset( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes MatthiasValvekens/pyHanko#319
Note: I have removed the now-unused constant
ACCEPTABLE_PKCS7_PEM_ALIASES. If we still want to keep it, I can revert that change.Tested locally with editable install: