Merge pull request faiface#134 from gopxl/fix-speaker-buffer-size

Fix speaker buffer size

speaker/speaker.go

@@ -35,20 +35,29 @@ func Init(sampleRate beep.SampleRate, bufferSize int) error {
 
 	mixer = beep.Mixer{}
 
+	// We split the total amount of buffer size between the driver and the player.
+	// This seems to be a decent ratio on my machine, but it may have different
+	// results on other OS's because of different underlying implementations.
+	// Both buffers try to keep themselves filled, so the total buffered
+	// number of samples should be some number less than bufferSize.
+	driverBufferSize := bufferSize / 2
+	playerBufferSize := bufferSize / 2
+
 	var err error
 	var readyChan chan struct{}
 	context, readyChan, err := oto.NewContext(&oto.NewContextOptions{
 		SampleRate:   int(sampleRate),
 		ChannelCount: channelCount,
 		Format:       otoFormat,
-		BufferSize:   sampleRate.D(bufferSize),
+		BufferSize:   sampleRate.D(driverBufferSize),
 	})
 	if err != nil {
 		return errors.Wrap(err, "failed to initialize speaker")
 	}
 	<-readyChan
 
 	player = context.NewPlayer(newReaderFromStreamer(&mixer))
+	player.SetBufferSize(playerBufferSize * bytesPerSample)
 	player.Play()
 
 	return nil