Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024q4 part 1 #618

Merged
merged 11 commits into from
Nov 4, 2024
Merged

Release 2024q4 part 1 #618

merged 11 commits into from
Nov 4, 2024

Conversation

grooverdan
Copy link
Member

No description provided.

START REPLIA was issued during initializing which mean that
even before /docker-entrypoint/initdb.d there was initializtion
going on.

Entrypoints that needed data initialzation didn't complete with
this nicely. Also if there wasn't any initialization there
would be little time for the replication to acheive anything
before being shutdown ready for the final start.

Moved --skip-slave-start to the default docker_temp_server_start
implementation.

Technically this is a compaibility break that is likely to be
of significants if:
* /docker-entrypoint/initdb.d contains a script waiting
  for replication to catch up.

The recitifcation to the previous behaviour is:
/docker-entrypoint/initdb.d contains a SQL to START REPLICA.
Recommend also having another script that is:

until healthcheck.sh --replication_io \
                     --replication_sql \
                     --replication_seconds_behind_master=0 \
                     --replication
                     --no-connect;
do
  sleep 1
done

Closes #614
There is an implicit --connect option in healthcheck
so that a normal use can be sure MariaDB is running
on a tcp socket.

There is a case in /docker-entrypoint-initdb.d where
its desirable to perform healthchecks for components
without a --connect. In this case, use --no-connect
in the healthcheck to avoid an implicit --connect test.
@grooverdan grooverdan merged commit c1fd2c4 into master Nov 4, 2024
9 of 12 checks passed
@jgb
Copy link

jgb commented Nov 8, 2024

Hello, when will 11.4.4 be available on docker hub? It's been a few days since the merge and I still see 11.4.3 as the latest version. Thanks!

@grooverdan
Copy link
Member Author

Because I removed 11.5, the there wasn't a branch to make latest without making 11.4, a (unsupported) downgrade the latest, so I'm waiting a few more days until 11.6/7 come out and do them all at once. Sorry for the delay.

@grooverdan
Copy link
Member Author

temporary version https://github.com/MariaDB/mariadb-docker/pkgs/container/mariadb/300198909?tag=11.4.4-noble

@grooverdan
Copy link
Member Author

docker-library/official-images#17905 when merged will build/push them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants