Create UBI minimal base image #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to resolve pmem dependencies in Dockerfile and complete the container build. update.sh mostly done. generate-stackbrew not done.
This is a minor API change when using UBI based container images.
Have same host-cache-size and skip-name-resolve settings as Ubuntu base images. Also use a socket location that is outside of the datadir which was the default for RPM distos and not Deb distros.
curl was in ubi9 base image and wget wasn't so use that. We use --location to follow the github redirect. Copy the verification step of gosu from Ubuntu base image. Best practices - consolidate common things so layers common to multiple images can occur. For compatibility with previous image install: * jemalloc (epel) * pwgen (epel) - secure passwords Liburing from AlmaLinux (messy - requested UBI inclusion https://issues.redhat.com/browse/RHEL-36705)
This facilitates and upgrade from mysql container where that is the uid used.
key for EPEL rpm to verify added. ARG/ENV for MARIADB_VERSION required for upgrade MARIADB_AUTO_UPGRADE. Remove pmem deps as they are now gone from RHEL9 releases. Trim down dependency list. Unfortunately boost-program-options still needed by galera even though only used for garb. procps-ng added for ps dependency in galera sst scripts. Add galera library symlink so will work with same configuration as Ubuntu base. Add healthcheck.sh script, same as others. Use mariadbd as command as we don't need to backwards compat anything.
Added thanks to Red Hat - RHEL-38361
Precreate /var/lib/mysql/mysql as this is what support-files/rpm/server-postin.sh in the server uses to determine if MariaDB is installed or not. Fake it, its the entrypoint's responsibility to create datadirectories. Also remove /var/run/mysql handling, its part of packaging.
/run/mariadb should be able to be written by any user in an unpriv mode, but that socket written there shouldn't be deletable by anyone, so sticky bit restricts this to the creating user. Align comments around galera and clarify that its the deb/rpm packaging differences that result in different locations.
tianon
reviewed
May 29, 2024
Also link to gosu license, by name at least. Test name: HasLicenses from Red Hat OpenShift Software Certification Policy Guide
This looks a bit outdates compared to the OCI standard, but its still part of OpenShift certification. The release gets populated with the Docker Official Images build.
For the moment hard code it, but using docker manifest inspect is almost there if something more automated is required.
ignore to top of file as its frequently edited near release
All changes needed to make a set of tags for ubi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a requirement for a UBI base image.
Entrypoint and healthcheck.sh are the same as the previous ubuntu image.