Fix cloud provision quota memory and cpu counting #22517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jaywcarman
commented
May 19, 2023
Cloud providers are not required to use flavors to set VM memory and cpu allocation during provisioning (for example IbmCloud::PowerVirtualServers::CloudManager). These 'number_of_cpus' and 'memory' methods are expected to return int values. In the case where a 'cloud' type provision is associated with a flavor without 'memory' or 'cpus' values the non-cloud logic is better than returning nil. Depending on how the provider implements the provision request, the return value will be something useful or just 0, avoiding raising an exception.
jaywcarman
force-pushed
the
fix_cloud_provision_quota_cpu_mem_calcs
branch
from
ac87c1f
to
8c04616
Compare
agrare
approved these changes
May 19, 2023
|
Checked commit jaywcarman@8c04616 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud providers are not required to use flavors to set VM memory and cpu allocation during provisioning (for example
IbmCloud::PowerVirtualServers::CloudManager). These 'number_of_cpus' and 'memory' methods are expected to return int values. In the case where a 'cloud' type provision is associated with a flavor without 'memory' or 'cpus' values the non-cloud logic is better than returning nil. Depending on how the provider implements the provision request, the return value will be something useful or just 0, avoiding raising an exception.This partially fixes the following provider issue. I also included information on how Flavor is used in PowerVS: