Automate Simulation Conversion Form from HAML to React

[liu-samuel]

Automation / Embedded Automate / Simulation

Converting the Automate Simulation Form from HAML to React and connecting the simulation tree summary to the form.

Old:

New:

[jeffibm]

When we change the Type drop down, we get an error. could you check this please -

[jeffibm]

Could you make the title look the same if possible, like making them the same font size.

[jeffibm]

There is a failing test case under the GitHub actions/spec:routes. Could you please have a look at it..

[liu-samuel]

Could you make the title look the same if possible, like making them the same font size.

Do you mean the "Simulation" text? I can't really see a difference between the old and new version

[GilbertCherrie]

Leaving this as a reference for later.

To do:

• Figure out what to do with the copy button (either remove the button or change the way it works)
• Add the ability for the form to pre load values that were previously selected

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[GilbertCherrie]

@liu-samuel can you please fix the tests here and also the old form has this flash message when the form is submitted:

can you please add this to your form too.

[GilbertCherrie]

Also, the reset button also has a flash message that your form is missing.

Also when you reset the old form these are the values that the form gets reset to.

However, your form does not match this reset behaviour.

Can you please fix these issues too?

[GilbertCherrie]

Can you please look into the comments I made

[miq-bot]

Checked commit liu-samuel@d560e28 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
6 files checked, 38 offenses detected

app/controllers/miq_ae_tools_controller.rb

• ⚠️ - Line 347, Col 63 - Lint/UnusedBlockArgument - Unused block argument - i. You can omit the argument if you don't care about it.
• ⚠️ - Line 348, Col 65 - Lint/ShadowingOuterLocalVariable - Shadowing outer local variable - i.
• ❗ - Line 332, Col 7 - Naming/AccessorMethodName - Do not prefix reader method names with get_.
• ❗ - Line 349, Col 14 - Style/StringConcatenation - Prefer string interpolation to string concatenation.
• ❗ - Line 350, Col 14 - Style/StringConcatenation - Prefer string interpolation to string concatenation.
• ❗ - Line 360, Col 7 - Naming/AccessorMethodName - Do not prefix reader method names with get_.

app/views/layouts/_ae_resolve_options.html.haml

• ⚠️ - Line 4 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
• ⚠️ - Line 5 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
• ⚠️ - Line 6 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
• ⚠️ - Line 7 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
• ⚠️ - Line 7 - Line is too long. [88/80]
• ⚠️ - Line 8 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.

app/views/layouts/_content.html.haml

• 💣 💥 🔥 🚒 - Line 15 - Do not repeat id "#left_div" on the page
• 💣 💥 🔥 🚒 - Line 16 - Do not repeat id "#default_left_cell" on the page
• 💣 💥 🔥 🚒 - Line 19 - Do not repeat id "#left_div" on the page
• 💣 💥 🔥 🚒 - Line 20 - Do not repeat id "#default_left_cell" on the page
• ⚠️ - Line 15 - Classes should be listed before IDs (.sidebar-pf should precede #left_div)
• ⚠️ - Line 15 - id attribute must be in lisp-case
• ⚠️ - Line 26 - Hash attribute should end with one space before the closing brace or be on its own line
• ⚠️ - Line 26 - Hash attribute should start with one space after the opening brace
• ⚠️ - Line 26 - Line is too long. [153/80]
• ⚠️ - Line 27 - Classes should be listed before IDs (.row should precede #main-content)
• ⚠️ - Line 31 - id attribute must be in lisp-case
• ⚠️ - Line 32 - id attribute must be in lisp-case
• ⚠️ - Line 34 - Line is too long. [110/80]
• ⚠️ - Line 35 - Do not use inline style attributes
• ⚠️ - Line 35 - Hash attribute should end with one space before the closing brace or be on its own line
• ⚠️ - Line 35 - Hash attribute should start with one space after the opening brace
• ⚠️ - Line 35 - id attribute must be in lisp-case
• ⚠️ - Line 43 - Line is too long. [90/80]
• ⚠️ - Line 44 - Line is too long. [89/80]
• ⚠️ - Line 54 - Do not use inline style attributes
• ⚠️ - Line 54 - Hash attribute should end with one space before the closing brace or be on its own line
• ⚠️ - Line 54 - Hash attribute should start with one space after the opening brace
• ⚠️ - Line 54 - Line is too long. [82/80]
• ⚠️ - Line 54 - id attribute must be in lisp-case
• ⚠️ - Line 56 - Avoid using instance variables in partials views
• ⚠️ - Line 56 - Line is too long. [107/80]