Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Convert chargeback assignment tabs to react #9043

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GilbertCherrie
Copy link
Member

Converted Overview > Chargeback > Assignment tabs to React.

Before:
Screenshot 2024-01-17 at 3 19 25 PM

After:
Screenshot 2024-01-17 at 3 17 43 PM

@GilbertCherrie GilbertCherrie force-pushed the convert_chargeback_assignment_tabs branch from 1a683db to fa176b0 Compare January 18, 2024 18:22
@miq-bot
Copy link
Member

miq-bot commented Jan 18, 2024

Checked commit GilbertCherrie@fa176b0 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@GilbertCherrie GilbertCherrie changed the title Convert chargeback assignment tabs to react [WIP] Convert chargeback assignment tabs to react Jan 19, 2024
@miq-bot miq-bot added the wip label Jan 19, 2024
@GilbertCherrie
Copy link
Member Author

Changing the Assign To select value completely breaks the page with these new tabs. Changing this to a WIP PR for now. Might need to convert the whole form along with the tabs.

@miq-bot miq-bot added the stale label Apr 22, 2024
@miq-bot
Copy link
Member

miq-bot commented Apr 22, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

2 similar comments
@miq-bot
Copy link
Member

miq-bot commented Jul 29, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants