-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Settings replication form #9016
base: master
Are you sure you want to change the base?
[WIP] Settings replication form #9016
Conversation
hey @DavidResende0 , could you please add a few screenshots in here. |
a78716b
to
3cd6c6c
Compare
Checked commits DavidResende0/manageiq-ui-classic@213955a~...3cd6c6c with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/views/ops/_settings_replication_tab.html.haml |
A small suggestion that we can look into later - As you can see in the screenshots in PR description, when you add/edit a subscription, the entire form gets replaced. We have a similar logic in the #8710. One reason for taking this approach was that we would get an error message in the browser console saying you cannot include a Form within a Form. If possible we can proceed with a similar approach as we do for input parameters here - #9047 (comment) We can place the modal-box outside the actual form and handle the data logic within the parent component. |
Hey @DavidResende0 , |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
1 similar comment
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
Preview: