Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Convert settings authentication form #8961

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

GilbertCherrie
Copy link
Member

No description provided.

@miq-bot
Copy link
Member

miq-bot commented Jun 3, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

@GilbertCherrie GilbertCherrie force-pushed the convert_settings_authentication_form branch from 3992568 to fa0b7a8 Compare June 12, 2024 20:24
@miq-bot
Copy link
Member

miq-bot commented Jun 13, 2024

Checked commits GilbertCherrie/manageiq-ui-classic@b5a7dfa~...5456e41 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
3 files checked, 6 offenses detected

app/controllers/ops_controller/settings/common.rb

app/views/ops/_settings_authentication_tab.html.haml

  • ⚠️ - Line 5 - Avoid using instance variables in partials views
  • ⚠️ - Line 5 - Layout/SpaceInsideHashLiteralBraces: Space inside { detected.
  • ⚠️ - Line 5 - Layout/SpaceInsideHashLiteralBraces: Space inside } detected.
  • ⚠️ - Line 5 - Line is too long. [141/80]

@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2024

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Nov 1, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants