Parse the event url with Regex not split #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
parse_event_url_regex
branch
from
35935f5
to
6b905be
Compare
agrare
commented
Nov 20, 2024
app/models/manageiq/providers/ibm_power_hmc/infra_manager/event_target_parser.rb
Outdated
Show resolved
Hide resolved
agrare
commented
Nov 20, 2024
| end | ||
| when "VirtualSwitch", "VirtualNetwork" | ||
| if elems.key?(:manager_uuid) | ||
| new_targets << {:assoc => :hosts, :ems_ref => elems[:manager_uuid]} | ||
| if elems["manager_uuid"] |
There was a problem hiding this comment.
This changed from .key? to truthy because if it isn't matched the payload will have {"manager_uuid" => nil}
Fryguy
reviewed
Nov 20, 2024
app/models/manageiq/providers/ibm_power_hmc/infra_manager/event_target_parser.rb
Outdated
Show resolved
Hide resolved
|
Is there specs for this? I thought I saw a spec PR come through but I can't find it |
Yes this method is well covered by specs each type has a spec associated with it. I only added a test for the invalid LPAR uuid case. |
agrare
force-pushed
the
parse_event_url_regex
branch
from
6b905be
to
72222ab
Compare
Fryguy
reviewed
Nov 20, 2024
app/models/manageiq/providers/ibm_power_hmc/infra_manager/event_target_parser.rb
Outdated
Show resolved
Hide resolved
agrare
force-pushed
the
parse_event_url_regex
branch
from
72222ab
to
54de5f3
Compare
Fryguy
approved these changes
Nov 20, 2024
|
@Fryguy let me check if there is a spec for an invalid url first |
agrare
force-pushed
the
parse_event_url_regex
branch
from
54de5f3
to
123d5f0
Compare
agrare
commented
Nov 20, 2024
| </Metadata> | ||
| <EventType kb="ROR" kxe="false">ADD_URI</EventType> | ||
| <EventID kb="ROR" kxe="false">1639561179310</EventID> | ||
| <EventData kxe="false" kb="ROR">https://te.st:12443/rest/api/uom/ManagedSyste/e4acf909-6d0b-3c03-b75a-4d8495e5fc49/LogicalPartition/</EventData> |
There was a problem hiding this comment.
With this the regular expression returns nil to exercise that case
(byebug) raw_event[:data].match(%r{/rest/api/uom/(?:ManagedSystem/(?<manager_uuid>[^/]+)/)?(?<type>[^/]+)/(?<uuid>[^/]+)$})
nil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the greatest regular expression of all time :D but it passes the specs.
The URLs for events that we get from the specs are:
Critically we have to handle the optional
ManagedSystem/d47a585d-eaa8-3a54-b4dc-93346276ea37at the start of the url path, but if that is the whole path then we need it to match on type/uuid not manager_uuid