Remove prepend_namespace #551
Conversation
We do not use prepend namespace The feature is causing us to double the number of queries when looking up objects
|
Checked commit kbrock@0885f24 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
|
Oh interesting. So the vendor part of this was part of an idea to create namespaces for plugins. Plugins could then own their own namespace or even domain, and then provide concrete implementations of things like provisioning and event handling, where the core automation engine would have generic stuff and call into plug-in specific stuff. I don't believe this was ever completed, but do you see any vendor specific namespaces in manageiq-content? cc @agrare |
|
I don't recognize any of this but I like the idea of moving provider specific automate bits into their respective plugins |
|
@Fryguy I didn't look. I remember you saying that Tina introduced this but we never ended up using it (6 months ago when I was tracing automate), and I saw a branch yesterday and finally pushed it forward. When tracing the queries and walking through the code, it is a distraction to me, especially knowing they are useless queries. |
|
Yeah my only concern is that there is already some vendor namespaces built, that this would effectively break. If not, then I think we can merge. |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
We do not use
prepend_namespaceThe feature is causing us to double the number of queries when looking up objects
@Fryguy you mentioned that we are not using this.
It was an extension mechanism added by tina that seems to not be leveraged.
I just put this into a PR so I didn't have to have a local branch and have to remember where I saw this issue.