This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
[WIP] Move browser management to kaifuku #9994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshriver
commented
Mar 18, 2020
dajoRH
changed the title
|
@mshriver I'm itching to try it in one of my projects. did you make it work in integration tests ? |
mshriver
changed the title
|
@izapolsk Ronny just merged my PRs and released 0.3.0, worth a try on any projects you're working on. I just rebased this and will be testing it. |
Use webdriver-kaifuku, replacing most of the code in cfme.utils.browser remove convenience methods surrounding the manager singleton, and update framework interaction with the browser from that singleton phase one of changing how integration_tests handles browsers, phase two will be to move the manager instance to the contextual classes for UI/SSUI Address the traceback encoding in pytest hook for artifactor exception hook FIXES ManageIQ#8131
|
I detected some fixture changes in commit 0579fbd The local fixture
The local fixture
Please, consider creating a PRT run to make sure your fixture changes do not break existing usage 😃 |
mshriver
changed the title
|
Would you mind rebasing this Pull Request against latest master, please? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use webdriver-kaifuku, replacing most of the code in cfme.utils.browser
remove convenience methods surrounding the manager singleton, and update framework interaction with the browser from that singleton
phase one of changing how integration_tests handles browsers, phase two will be to move the manager instance to the contextual classes for UI/SSUI
PRT
Currently UI tests are failing with a screenshot showing the login screen, with no credentials filled. cfme.log shows navigation, form fill, and button click, needs local debug.