Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to fix s3 backup errors #1612

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Script to fix s3 backup errors #1612

wants to merge 3 commits into from

Conversation

etchegom
Copy link
Contributor

@etchegom etchegom commented Oct 14, 2024

Implémentation d'un script (oneshot) pour fixer les problèmes de backup s3, depuis le log issue de la commande de sync.

@etchegom etchegom self-assigned this Oct 14, 2024
@etchegom etchegom requested a review from a team as a code owner October 14, 2024 07:02
@etchegom etchegom requested review from kolok and syldb and removed request for a team October 14, 2024 07:02
Copy link

github-actions bot commented Oct 14, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8307 6906 83% 80% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: fde907d by action🐍

Copy link

sonarcloud bot commented Nov 8, 2024

Copy link
Collaborator

@kolok kolok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'avais oublié d'envoyer le commentaire que j'avais fait sur cette PR :)

"upload_file_uuid": parts[1],
}

def _get_conv_upload_fields(self) -> list[str]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour s'assurer qu'on modifie le champ et lui seul, on peut lever une exception si la fonction renvoie plus de 1 ou 0 champ

@kolok kolok added the bug Something isn't working label Nov 21, 2024
@etchegom
Copy link
Contributor Author

Le dernier backup S3 sur le CI est Ok => https://github.com/MTES-MCT/apilos/actions/runs/11884777719
En rejouant le sync en local, je n'est plus de log d'erreur en output. Est-ce une montée en version du aws cli qui aurait fixé le problème? Je vais vérifier le changelog.
En tous cas, ce n'est peut etre pas utile de merger cette PR pour le moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants