-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional MPAS-seaice plots for snow analyses #1036
Conversation
These plots are being added to enable a more comprehensive (but quick) analysis of an E3SM simulation campaign investigating the impacts of advanced snow physics processes in MPAS-seaice. The fields being added here (snow volume, albedo and the area and volume tendencies) are fundamental when considering any sea ice simulations. For Notes:
How is authorship determined? I am happy to include whomever should be acknowledged on those lines (understanding that I modified the existing timeseries file and copied one of Darin's climatology files). |
Sorry for the delay. I'm very excited to review this! |
I'm adding a few more fields now - hold off a bit please - but I would appreciate your suggestions for how it could be done better / more efficiently. |
I've added ridging diagnostics and updated some of the other fields, and remade all the plots for 1950-1999. E.g. see https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.eclare/E3SMv3/MPAS_analysis/1950-1999/snow_off/sea_ice/index.html |
These additional plots look great! One thing you may want to play around with is different colormaps for different fields. I at least really like being able to quickly distinguish between different fields based on colormap. There is a flag to
That might be helpful. |
If you copy them somewhere on the web portal, they should be viewable. If necessary, you can scp them to your laptop. However, I'll take a look at the docs as part of my review so no worries. |
I think we need to add new entries in this directory for each new task. You should be able to copy the documentation for an existing task and delete the part about observations (since my understanding is that the new tasks don't have observations yet). https://github.com/MPAS-Dev/MPAS-Analysis/tree/develop/docs/users_guide/tasks The tasks will then need to be listed in the main index of tasks: |
After doing a test merge with I'll run some tests on higher resolution runs as well as soon as I can. I just wanted to do some basic sanity checking first. |
I updated the documentation on blues and scp'd it to my laptop to view. I hope it's complete now! |
Wonderful, thank you! Looks good to me. @darincomeau, do you have time to have a look at this in the next day or 2? |
@darincomeau, if you can run analysis with this branch on one of the SORRM v3 simulations, that would be very helpful. I'll then sign off on the PR. |
@eclare108213, my only remaining comment would be that I think maybe this colormap might be fairly low contrast and thus it might be difficult to distinguish different ridged ice thicknesses from one another. I grant you that the contouring makes the different levels pretty clear even so. I very much like your other colormaps you've chosen. |
Thanks, @eclare108213, I think those levels are certainly easier to distinguish. I imagine we will want to revisit the color maps and contour values down the road once we have some more experience with these plots across a variety of simulations. That has certainly been the case with similar plots in the past. |
Yes, I also expect the contours and colors to be adjusted. I've just added a note to the docs regarding albedo. For quick-look comparisons across simulations at the same time, these plots can be helpful, but one needs to be extremely careful when looking at albedo across time. I included them because albedo is such an important part of the story for evaluating simulations with differing snow physics, but we might consider commenting them out going forward to emphasize "user beware". |
image_caption = f'{season} Climatology Map of ' \ | ||
image_caption = f'Climatology Map of ' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing these.
climatologyMapSeaIceAlbedoSH | ||
============================ | ||
|
||
An analysis task for plotting maps of Arctic sea ice broadband albedo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A copy-and-paste error in the last commit:
An analysis task for plotting maps of Arctic sea ice broadband albedo. | |
An analysis task for plotting maps of Antarctic sea ice broadband albedo. |
Years 21 - 30 of the "alfred1" run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eclare108213 this is alot of work, and so great to have these additional plots!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @darincomeau, for your plots.
And, yes, thanks @eclare108213 for this tremendous work and for all you had to do to figure out MPAS-Analysis to make it happen. This will make a huge difference in our ability to analyze sea ice going forward!
Adding sea ice timeseries plots for snow volume and climatology plots for snow volume, broadband albedo, and ice area and volume tendencies due to thermodynamics and transport.
Checklist
api.rst
) has any new or modified class, method and/or functions listedTesting
comment in the PR documents testing used to verify the changes