fix(build_docs.py): filter benchmark artifacts by branch #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub API list artifacts endpoint does not provide a way to filter by the branch an artifact was produced from, and will return all artifacts for a repo, even those produced by open PR runs. The
distribution/build_docs.pyscript previously just took the first artifact namedrun-time-comparisonit could find. This broke the nightly build full distribution tests — an artifact from #1328 was picked up despite its contents being named differently/incompatibly with the current state ofdevelop. Add a filter to make sure the artifact used inbuild_docs.pywas produced by a workflow run ondevelop.