Adding matching type URL to warninglists #169
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All MISP Warninglists are not created equal. MISP warninglists have their characterization defined by specifying types in their “matching_attributes” --> Ex: "matching_attributes": ["domain", "hostname", "url" ],
The issue we are seeing is that a domain can also be an URL but some warninglists are missing the “matching_attributes” “URL” so the IoC will not be blocked if the type is “URL”.
Like in the below example, if the attribute (IoC) type is URL and the warninglisst doesn’t have the “matching_attributes” “URL”, the warninglists its ignored by MISP.
The attribute (IoC) “0f3kjf7t0dbj.wpeproxy.com” with type “domain” and “URL” is part of a warninglist with “domain” and “URL” matching_attributes. This causes the warninglist to block both attributes since it’s a protected domain and URL.
--> "matching_attributes": ["domain", "hostname", "url"]
The attribute (IoC) “fs.microsoft.com” with type “domain” and “URL” is part of LIST OF KNOWN WINDOWS 10 CONNECTION ENDPOINTS with only the “domain” attributes. This causes the warninglists to block only the domain attributes since it’s a protected domain. The URL IoC will not be blocked since the warninglists haven’t detected the “URL” type.
--> "matching_attributes": ["domain", "hostname", "domain|ip"]