Fix error in parallelization scheme #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4760 +/- ##
===========================================
- Coverage 93.65% 93.63% -0.03%
===========================================
Files 175 187 +12
Lines 21565 22640 +1075
Branches 3023 3024 +1
===========================================
+ Hits 20196 21198 +1002
- Misses 925 998 +73
Partials 444 444 ☔ View full report in Codecov by Sentry. |
orbeckst
approved these changes
Oct 24, 2024
| @@ -41,7 +41,8 @@ impossible with any but the ``serial`` backend. | |||
|
|
|||
| Parallelization is getting added to existing analysis classes. Initially, | |||
| only :class:`MDAnalysis.analysis.rms.RMSD` supports parallel analysis, but | |||
| we aim to increase support in future releases. | |||
| we aim to increase support in future releases. Please check issues labeled | |||
| `parallelization` on the MDAnalysis issues [page](https://github.com/MDAnalysis/mdanalysis/issues). | |||
There was a problem hiding this comment.
|
@IAlibay I assigned the PR to you so you can make the decision about merging despite 2.8.0 feature freeze. |
IAlibay
reviewed
Oct 25, 2024
package/doc/sphinx/source/documentation_pages/analysis/parallelization.rst
Outdated
Show resolved
Hide resolved
IAlibay
reviewed
Oct 25, 2024
package/doc/sphinx/source/documentation_pages/analysis/parallelization.rst
Outdated
Show resolved
Hide resolved
IAlibay
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in this Pull Request:
PR Checklist
Developers certificate of origin
📚 Documentation preview 📚: https://mdanalysis--4760.org.readthedocs.build/en/4760/