-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timestep #4447
Open
nataliyah123
wants to merge
13
commits into
MDAnalysis:develop
Choose a base branch
from
nataliyah123:timestep
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
timestep #4447
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
70e036f
tim
nataliyah123 f97dd30
timestep not working
nataliyah123 1af773c
timestep errors _v1
nataliyah123 2df693b
minor mistakes
nataliyah123 18696b5
rounding the values as requested
nataliyah123 198eaf3
some checks
nataliyah123 a545ba2
some_changes_v2
nataliyah123 ac4519b
recompiled timestep.py
nataliyah123 a5bb78e
Update AUTHORS
nataliyah123 9cbc432
Merge branch 'develop' of https://github.com/MDAnalysis/mdanalysis in…
nataliyah123 578218f
added to authors
nataliyah123 ba8dee3
Merge branch 'timestep' of https://github.com/nataliyah123/mdanalysis…
nataliyah123 1e5ae0d
added to changelog
nataliyah123 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You made some progress, but now the doctest if failing on comparison with this array, try and reduce the precision of the comparison. Have a detailed look at the output of make doctest to see if your changes are working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hmacdope . I rounded the values. it does reflect in doctest.