Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy.yaml #77

Merged
merged 5 commits into from
Oct 29, 2023
Merged

Fix deploy.yaml #77

merged 5 commits into from
Oct 29, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 29, 2023

Fixes #

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

I'll add a test shim to check if it was just the quotes.

@IAlibay IAlibay temporarily deployed to deploy October 29, 2023 07:38 — with GitHub Actions Inactive
@IAlibay IAlibay temporarily deployed to deploy October 29, 2023 07:38 — with GitHub Actions Inactive
@IAlibay
Copy link
Member Author

IAlibay commented Oct 29, 2023

Ok that was it - looks like just quotes being a pain.

@lilyminium
Copy link
Member

Thanks for the fix!

@lilyminium lilyminium merged commit 0211d5b into main Oct 29, 2023
4 of 5 checks passed
@lilyminium lilyminium deleted the fix-deploy branch October 29, 2023 07:43
@lilyminium
Copy link
Member

Worked like a charm, thank you @IAlibay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyminium lilyminium lilyminium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IAlibay @lilyminium