Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout options #68

Merged
merged 9 commits into from
Sep 21, 2023
Merged

Update layout options #68

merged 9 commits into from
Sep 21, 2023

Conversation

lilyminium
Copy link
Member

Fixes #66

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@pep8speaks
Copy link

pep8speaks commented Sep 21, 2023

Hello @lilyminium! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 100:80: E501 line too long (83 > 79 characters)
Line 119:80: E501 line too long (81 > 79 characters)

Line 43:27: E203 whitespace before ':'
Line 87:80: E501 line too long (122 > 79 characters)
Line 88:80: E501 line too long (120 > 79 characters)
Line 89:80: E501 line too long (98 > 79 characters)

Comment last updated at 2023-09-21 22:50:33 UTC

@lilyminium lilyminium marked this pull request as ready for review September 21, 2023 22:46
@lilyminium lilyminium merged commit 100ceed into main Sep 21, 2023
1 check passed
@lilyminium lilyminium deleted the update-theme-layout branch September 21, 2023 23:05
@IAlibay
Copy link
Member

IAlibay commented Sep 22, 2023

I'm just catching up with everything, any chance you can add in line comments to document the changes you're making in init and in navigation.html? Otherwise things are going to add up such that the day you're not around to fix this it's going to take a ton of time to understand what everything is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black navbar
3 participants