Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update ConvMixer to support reactant #1063

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 9, 2024

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.77%. Comparing base (04494b5) to head (e5d140c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/layers/pooling.jl 0.00% 4 Missing ⚠️
ext/LuxReactantExt/patches.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (04494b5) and HEAD (e5d140c). Click for more details.

HEAD has 49 uploads less than BASE
Flag BASE (04494b5) HEAD (e5d140c)
72 23
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1063       +/-   ##
===========================================
- Coverage   83.79%   73.77%   -10.02%     
===========================================
  Files         147      146        -1     
  Lines        6036     6014       -22     
===========================================
- Hits         5058     4437      -621     
- Misses        978     1577      +599     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal changed the title docs: update ConvMixer to support reactant feat: update ConvMixer to support reactant Nov 10, 2024
Copy link
Contributor

github-actions bot commented Nov 11, 2024

Benchmark Results (ASV)

main e5d140c... main/e5d140c3b4096b...
basics/overhead 0.12 ± 0.00066 μs 0.133 ± 0.0019 μs 0.905
time_to_load 1.14 ± 0.0082 s 1.15 ± 0.0046 s 0.998

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal avik-pal force-pushed the ap/conv_mixer_reactant branch 2 times, most recently from 25f13de to ee2fb4f Compare November 15, 2024 02:55
src/layers/pooling.jl Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant