Features #3
Features #3
Conversation
Added the option to select a SuffixSort algorithm Replaced WriteInt64 with a faster method Fixed an erroneous throw if a patch completes without any extra data Fixed db/eb being allocated with an extra byte Moved constant fields together
This reverts commit c563cb5.
Added the option to select a SuffixSort algorithm
| m_pos = pos; | ||
| m_array = array; | ||
| } | ||
| ~ByteArray() |
There was a problem hiding this comment.
Types that don't own native resources shouldn't have finalizers. (Writing a finalizer for any type shouldn't be necessary; see Never write a finalizer again (well, almost never).)
There was a problem hiding this comment.
I see now that this was probably taken from https://sites.google.com/site/yuta256/sais. Still, it would be a good idea to clean it up and bring it in conformance with proper C# style.
There was a problem hiding this comment.
Yes, as I said in my pull request and commit comments, this is Yuta Mori's SAIS implementation, verbatim.
I have cleaned it up quite a bit in my ttwinstaller repo, which you're welcome to snag if you plan on keeping SAIS.
There was a problem hiding this comment.
Thanks, I'll take a look at that.
|
it have problem in mac system. after patch, it is different old file and new file. |
Added Yuta Mori's induced sort
Added the option to select a SuffixSort algorithm
Replaced WriteInt64 with a faster method