Skip to content

Commit

Permalink
Request only a single JS bundle from index.ts
Browse files Browse the repository at this point in the history
We introduce a new `indexDelayed.ts` file that bundles all the imports
that are used in the `index.ts` file. They are not imported directly
there, because we want to keep the size of the `index.html` as small as
possible, so it can focus on requesting the WASM file as soon as
possible. This should result in the `indexDelayed.ts` bundle containing
basically all the JS. This JS bundle and the WASM file should then be
requested in parallel. While it would be possible to request these all
individually over in the `index.ts`, browsers don't actually like doing
too many requests in parallel and it turns out that big JavaScript files
actually compress better than having many small ones. The WASM file also
is pretty big, so ideally we are not bottlenecked by the large JS file.
If necessary, we could do some more bundle splitting for stuff that
isn't used until much later, like the Markdown library.
  • Loading branch information
CryZe committed Jun 19, 2024
1 parent 9f3ed50 commit 992e391
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 9 deletions.
10 changes: 1 addition & 9 deletions src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,7 @@ import "./css/main.scss";
import("./css/font-awesome.css");

try {
const [
{ LiveSplit },
React,
{ createRoot },
] = await Promise.all([
import("./ui/LiveSplit"),
import("react"),
import("react-dom/client"),
]);
const { LiveSplit, React, createRoot } = await import("./indexDelayed");

try {
const {
Expand Down
19 changes: 19 additions & 0 deletions src/indexDelayed.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// This file bundles all the imports that are used in the index.ts file. They
// are not imported directly there, because we want to keep the size of the
// index.html as small as possible, so it can focus on requesting the WASM file
// as soon as possible. This should result in this file containing basically all
// the JS and the WASM file being requested in parallel. While it would be
// possible to request these all individually over there, browser don't actually
// like doing too many requests in parallel and it turns out that big JavaScript
// files actually compress better than having many small ones. The WASM file
// also is pretty big, so ideally we are not bottlenecked by the large JS file.
// If necessary, we could do some more bundle splitting for stuff that isn't
// used until much later, like the Markdown library.

// FIXME: Look into pulling even more CSS out of the index.ts as well.

import { LiveSplit } from "./ui/LiveSplit";
import React from "react";
import { createRoot } from "react-dom/client";

export { LiveSplit, React, createRoot };

0 comments on commit 992e391

Please sign in to comment.