Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bless on Rosetta capable environments(arm64) #223

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SReject
Copy link

@SReject SReject commented Mar 2, 2023

Issue:
- bless doesn't support --openfolder for Apple Silicon based architectures.
- With Rosetta transcoding the current check of os.arch() returns x86; this is why #205 did not solve the issue.
- Other node-native potential checks also fail to identify Apple Silicon environments

Fix:
- Check sysctl.proc_translated and if it has a value assume the machine is Rosetta-capable and thus Apple Silicon

Implementation:
- use sysctl command to retrieve the value of sysctl.proc_translated. If a value is returned it can be assumed the machine is Rosetta-capable.
- Do not use --openfolder when Rosetta-capability has been assumed.

Tests:
- MacBook Air, 2020 (M1)
- MacBook Pro, 2021 (M1 Pro)

Addresses:
#216, #218, #219

@SReject SReject changed the title fix: bless for Rosetta capable environments(arm64) fix: bless on Rosetta capable environments(arm64) Mar 2, 2023
@jjeff
Copy link

jjeff commented May 20, 2023

Giving this a nudge.

By default, Github Actions Runner runs in Rosetta mode on Apple Silicon devices. This means that currently, node-appdmg won't work in a Ventura CI build environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants