fix/base-url #159
Open
fix/base-url #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RegexLimit update Regex.swift. Upgrade regex limit length
When an image URL is not an absolute URL (ie. protocol://url), we want to put the base URL in front of it, if it is known. BUT, if neither the base URL ends in / or the image URL start with /, the current formatImageURL mashes them together without a slash, leading to something like https://base.comimages/image.jpg
|
It looks like your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
When a base URL and an image URL are combined but there is no trailing / in base and no leading slash in image, they get mashed together badly:
https://base.comimages/image.jpg