FIXED: Amazon links did not contain og tags with the default user agent #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added 'userAgent' with a default value to preserve current behavior - Included the 'googleBotUserAgent' static which can be used to override the default - Not only does it include OG tags but the pages are way smaller due to Amazon optimizing for google search indexing (huge performance boost to SLP) - Added unit tests for Amazon links and tested across several other major ecommerce sites
|
@LeonardoCardoso I forked and made this change for my project. I'm getting better results with the google bot user agent across all sites but I left the default user agent in place so it doesn't change existing behavior. I don't often contribute back so let me know if this was the right way to do it and I can update. Hope this helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Action
ADDED: 'userAgent' with a default value to preserve current behavior
ADDED: 'googleBotUserAgent' static which can be used to override the default
ADDED: unit tests for Amazon links and tested across several other major ecommerce sites
NOTE: Not only does this fix OG tags for amazon.com links but the pages are way smaller due to Amazon optimizing for google search indexing (huge performance boost for preview response times)