Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more healthly way to access to iconsjson string #17

Merged
merged 2 commits into from
May 11, 2024
Merged

Implement more healthly way to access to iconsjson string #17

merged 2 commits into from
May 11, 2024

Conversation

hawl1
Copy link
Contributor

@hawl1 hawl1 commented May 11, 2024

it really makes an issue to be honest.

@LelouchFR
Copy link
Owner

LelouchFR commented May 11, 2024

@hawl1 since the Build are failing, can you say me what to change in the build.yml file to make it work again (since I'm sure your code is clean) ?

Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LelouchFR LelouchFR merged commit 2d31066 into LelouchFR:main May 11, 2024
1 check failed
@hawl1
Copy link
Contributor Author

hawl1 commented May 11, 2024

@hawl1 since the Build are failing, can you say me what to change in the build.yml file to make it work again (since I'm sure your code is clean) ?

its because i dont have a vercel token

@hawl1
Copy link
Contributor Author

hawl1 commented May 11, 2024

@hawl1 since the Build are failing, can you say me what to change in the build.yml file to make it work again (since I'm sure your code is clean) ?

its because i dont have a vercel token

oh wait, its because vercel thinks that icons.go is a function

@LelouchFR
Copy link
Owner

@hawl1 since the Build are failing, can you say me what to change in the build.yml file to make it work again (since I'm sure your code is clean) ?

its because i dont have a vercel token

No, I've done a special one to check if it can at least build, if the code builds, it's all good to be merged, look build.yml file

@LelouchFR
Copy link
Owner

Oh yes wait, it does also no want to deploy too, so no workflow works at all... yeah idk, that seems strange

@hawl1
Copy link
Contributor Author

hawl1 commented May 11, 2024

Oh yes wait, it does also no want to deploy too, so no workflow works at all... yeah idk, that seems strange

after looking around, vercel just dont like variables on seperate files...
its possible to revert commits by using git revert
sorry for any stuff that happened -_-

@LelouchFR
Copy link
Owner

Oh yes wait, it does also no want to deploy too, so no workflow works at all... yeah idk, that seems strange

after looking around, vercel just dont like variables on seperate files... its possible to revert commits by using git revert sorry for any stuff that happened -_-

No Problem, I did undertsand what you wanted to do and is literally the way to do, (ran go run build.go then looked at the index.go file and my neovim had a struggle with it xD), I'm going to revert it but no problem, it was done for good purposes so no problem brother ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants