Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created 45 degree buffers #510

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

cakeGit
Copy link
Contributor

@cakeGit cakeGit commented Aug 5, 2024

Copy link
Member

@techno-sam techno-sam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! Thank you!

Two things that need to be tested:

  • Buffers in existing worlds don't have their BlockState messed up
  • Diagonal buffer placement 'feels' right (always faces an expected & reasonable direction when placed, aka not perpendicular to the track or flipped relative to player view direction)

Copy link
Member

@techno-sam techno-sam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@techno-sam techno-sam merged commit 02b2224 into Layers-of-Railways:1.19/dev Aug 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants