Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 309 cl data vector #327

Merged
merged 38 commits into from
Jul 17, 2024
Merged

Issue 309 cl data vector #327

merged 38 commits into from
Jul 17, 2024

Conversation

marina-ricci
Copy link
Contributor

@marina-ricci marina-ricci commented Oct 23, 2023

This PR is dedicated to put together the different part of the Cluster pipeline.

@marina-ricci
Copy link
Contributor Author

Trying to work on feeding cluster ensemble with cluster tomography :
image

@marina-ricci
Copy link
Contributor Author

This is what I obtain for the ensemble profile on the 20deg2 :
image
The error bars are from the sample covariance.

@marina-ricci
Copy link
Contributor Author

This is the stacked profiles in bin of redshift/richness for 20deg2. There is a clear problem with the profile, but the pipeline is running !
image

@marina-ricci
Copy link
Contributor Author

There is also a problem to fix maybe on the CLMM side : when there is no background galaxy in a radial bin we want to fill the profile with None to preserve the size of the profile otherwise we can't stack.

@marina-ricci
Copy link
Contributor Author

What was done :
we now have preliminary pipeline to compute stacked delta_sigma profiles for each richness/redshift bins. This works on the 20deg2 extracted from cosmoDC2.
Problems, limitations and to-dos so far :

  • The cluster_esemble stage output pickle files. All Cluster related stage are not parallelized. This may not scale.
  • There is a clear problem with a profiles that are wrong. I suspect a problem in the cluster_shear stage. We need to investigate.
  • There is a problem with the radius : if a given cluster does not have background source in a given radial bin, this prevent the stack to be compute. This likely has to be changed in CLMM directly.
  • We miss the last stage to read outputs and only save needed information in SACC format.

@combet
Copy link
Contributor

combet commented Feb 26, 2024

  • There is a problem with the radius : if a given cluster does not have background source in a given radial bin, this prevent the stack to be compute. This likely has to be changed in CLMM directly.

In CLMM, make_radial_profile has a keyword include_empty_bins that is False by default. Turning it to True when calling that function in TXPipe (here) should solve the problem (I think).

@marina-ricci
Copy link
Contributor Author

Ah great! I'll update that then (Or anyone before me)

@combet
Copy link
Contributor

combet commented Mar 7, 2024

@marina-ricci - I started completing the CLClusterShearCatalogs demo notebook, in the spirit of what you did for the counts one. Not finished and still needs work though.

@marina-ricci
Copy link
Contributor Author

I need someone looking that Run_CL_pipeline.ipynb makes sense and runs at CCin2P3 and nersc.

@marina-ricci
Copy link
Contributor Author

marina-ricci commented Jul 17, 2024

OK, we noticed some bugs at nersc but this is most probably due to the installation, as the CLMM version is too old. This PR works with CLMM v1.8.0 (not the latest version). I would like to proceed with the merge as it works at CCin2p3 and marginally at NERSC (only the clusterensemble part fails). We can (and should) update it later but this will be too big for this PR. @combet and @cavestruz I would be happy if you can accept (no need for thorough review). There are some test failing but that does not come from this PR.

@marina-ricci marina-ricci marked this pull request as ready for review July 17, 2024 13:19
Copy link
Contributor

@cavestruz cavestruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the PR, but a quick note that we (likely Tomomi) will need to explicitly run the notebooks on NERSC still.

name: cori-batch
image: ghcr.io/lsstdesc/txpipe-dev
#site:
# name: cori-batch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still cori-batch? Or perlmutter-batch?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be nersc-batch now.

@marina-ricci
Copy link
Contributor Author

Yes, and there will likely be needed updates with the new CLMM version.

@marina-ricci marina-ricci merged commit 97c80d5 into master Jul 17, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants