-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 309 cl data vector #327
Conversation
…e_309_CL_data_vector
There is also a problem to fix maybe on the CLMM side : when there is no background galaxy in a radial bin we want to fill the profile with None to preserve the size of the profile otherwise we can't stack. |
What was done :
|
In CLMM, |
Ah great! I'll update that then (Or anyone before me) |
… into issue_309_CL_data_vector
@marina-ricci - I started completing the CLClusterShearCatalogs demo notebook, in the spirit of what you did for the counts one. Not finished and still needs work though. |
…e_309_CL_data_vector
…C/TXPipe into issue_309_CL_data_vector
I need someone looking that |
OK, we noticed some bugs at nersc but this is most probably due to the installation, as the CLMM version is too old. This PR works with CLMM v1.8.0 (not the latest version). I would like to proceed with the merge as it works at CCin2p3 and marginally at NERSC (only the clusterensemble part fails). We can (and should) update it later but this will be too big for this PR. @combet and @cavestruz I would be happy if you can accept (no need for thorough review). There are some test failing but that does not come from this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve the PR, but a quick note that we (likely Tomomi) will need to explicitly run the notebooks on NERSC still.
name: cori-batch | ||
image: ghcr.io/lsstdesc/txpipe-dev | ||
#site: | ||
# name: cori-batch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still cori-batch
? Or perlmutter-batch
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be nersc-batch
now.
Yes, and there will likely be needed updates with the new CLMM version. |
This PR is dedicated to put together the different part of the Cluster pipeline.