Updating CI workflow #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosggarcia Ready to review, finally! |
|
Note that the build check will never pass as it's been changed. We will need to update this once the PR is merged. |
| if: steps.cache.outputs.cache-hit == 'true' | ||
| run: | | ||
| mamba install -y openmpi | ||
| pip install -U mpi4py --no-cache-dir --no-deps |
There was a problem hiding this comment.
why both mamba and pip?
There was a problem hiding this comment.
I'm honestly not sure how to tell conda to build with MPICH or OpenMPI? By using --no-deps we prevent pip from installing any dependencies besides just the mpi4py module
There was a problem hiding this comment.
whatever, if it works, let's leave it like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to expand our test coverage and unify the CI workflow with the regular development workflow. This is useful because we want the build action to reflect the development workflow that a user who is contributing to the codebase would experience. Currently the two are pretty disjointed (different installs etc).
ci.yaml fileThe new workflow is
lint>tests>publishenvironment.ymlfileenvironment.ymlto include all development dependencies, and instructing a user to pip install with --no-deps to prevent dependency clashes. Removing defaults from channels to prevent similar issues