-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perlmutter scheduling #775
Merged
burlen
merged 14 commits into
temporal_reduction_multiple_steps_per_request
from
perlmutter_scheduling
Aug 31, 2023
Merged
Perlmutter scheduling #775
burlen
merged 14 commits into
temporal_reduction_multiple_steps_per_request
from
perlmutter_scheduling
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burlen
changed the base branch from
develop
to
temporal_reduction_multiple_steps_per_request
August 28, 2023 18:48
This was
linked to
issues
Aug 28, 2023
burlen
force-pushed
the
perlmutter_scheduling
branch
from
August 28, 2023 19:09
55c34f5
to
c80b3f1
Compare
burlen
force-pushed
the
perlmutter_scheduling
branch
from
August 29, 2023 21:30
c80b3f1
to
aafdcc2
Compare
burlen
force-pushed
the
perlmutter_scheduling
branch
from
August 30, 2023 16:21
aafdcc2
to
4e90eb2
Compare
add an algorithm property that allows threads in the thread pool to inherit their device assignment from the down stream. This reduces inter device data movement when chaining thread pools.
burlen
force-pushed
the
perlmutter_scheduling
branch
from
August 30, 2023 16:53
4e90eb2
to
812a601
Compare
burlen
force-pushed
the
perlmutter_scheduling
branch
from
August 30, 2023 19:42
bf05a56
to
ebea8ff
Compare
was forwarding to teca_algorithm which resulted in none of the threading related properties being picked up from the command line.
This fixes a bug introduced in 7120ecb. There the early termination criteria was dropped from the loop that scans for completed work. Early termination is the basis for streaming and without it we were waiting for all work to complete before returning effictively disabling streaming.
when the requested the numebr of threads is less than -1, use at most this many threads. fewer may be used if there are insufficient cores on the node.
burlen
force-pushed
the
perlmutter_scheduling
branch
from
August 31, 2023 16:33
ebea8ff
to
1d5f415
Compare
don't issue the warning when MPI is used
|
burlen
merged commit Aug 31, 2023
90500dc
into
temporal_reduction_multiple_steps_per_request
1 check passed
@amandasd merged to your branch. some critical fixes here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling work to determine the best way to use a single Perlmutter GPU node given the interplay between MPI, threads, CUDA, and NetCDF/HDF5.
resolves #772
resolves #769