WIP -- Parallelize GFDL TC detector using OpenMP #763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is easy to do and will speed things up when the candidate stage is called on a single time step. But this will have to be used with care since it would potentially conflict with our typical use of thread pools. We might make this the default and then override in our apps that use thread pools so that Python users would get parallel code when processing a single time step.
We'll have to add an addition table_sort to our regression tests since the candidates are no longer generated in a deterministic order.
Would be nice to automate OpenMP settings. I've made an initial pass at this. It would be better to use MPI to coordinate the assignment of threads to core across ranks on the node. We do this for our thread pools. I'm not sure we can make use of MPI in the library constructor , which is where we have to put OpenMP settings.
initial results are positive, this is a Debug build