Remove omega0
from explicit inclusion in optical_element
#323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a suggested modification to the
optical_element
class to removeomega0
from explicit inclusion in the methodamplitude_multiplier
.I find it somewhat confusing that we have both$\Delta \omega$ such that for each optical element we would need to use
omega
andomega0
as input arguments. Seeing them both, I would automatically assume that the frequency axisomega
is then actually centered around 0, and thatomega
is ratheromega + omega0
but this is not the case. Instead all but one of our optical elements do not useomega0
at all.I understand that this was specifically introduced in #261 for the case of polynomial spectral phase #263 . Here I believe we should instead add
omega0
as an argument required for initialisation of this optic. This optic adds spectral phase as a polynomial expansion of frequency and so defining the central frequency explicitly is, I think, a good idea.In any case, as mentioned this is just a suggestion so totally fine to not make the change if people prefer it the way it is. Everything mechanically works great as is
@soerenjalas , could you take a look and see what you think, given you created the two PRs above