feat: add hoangndst as approver of kusion #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-hm19
requested review from
SparkYuan,
ffforest,
elliotxx,
Yangyang96 and
adohe
Yangyang96
approved these changes
Aug 30, 2024
|
@liu-hm19 Let's just make it happen, and thanks @hoangndst very much for your contribution👍 |
Happy to contribute to the community, and I am looking forward to many more great things with the KusionStack community! Thanks all you guys! |
|
@hoangndst Thanks for your contribution and welcome to our community! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the first PR submitted on Jun 27 (#1189), @hoangndst has been very active in KusionStack community, implementing the optimization of imported resources (#1239 and #1260), the support for
Viettel CloudSecrets Manager (#1267), and thekusion release showcommand (#1265).I believe @hoangndst has the ability to independently review and merge codes into the Kusion repository, and take responsibility for Kusion's major features. Thus I nominate @hoangndst as an Approver for Kusion.
I have added the main maintainers of Kusion repository as the reviewers for this nomination. If you also approve @hoangndst to be an Approver for Kusion, please leave a thumb-up (👍) on this comment before Sep 15.