Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality to show first five messages in statistics view #60

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

cathyxfeiyang
Copy link

@cathyxfeiyang cathyxfeiyang commented Apr 28, 2024

Description

I added functionality to show first five messages in a conversation (as requested by original repo maintainer). After the user clicks on a conversation to open its statistics popup, there is a listbox showing the first five messages in that conversation with their respective senders. I'm hoping that this can help users easily look back on how their conversations started with friends.

Screen.Recording.2024-04-27.at.8.09.02.PM.mov

Fixes #29

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue):

  • Changed logic of opening Statistics popup: in the unchanged version, opening the statistics popup for a conversation sometimes ran into bugs of "no conversation selected," since the popup was bound to a double click action. I changed this so a conversation is set to current_conversation on click, and the statistics popup opens with this selection.

  • New feature (non-breaking change which adds functionality)

  • Added functionality in statistics view to show the first five messages in the conversation.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  1. Load sample data
  2. Click on a private conversation (private chat) and verify that the statistics popup for that conversation is opened
  3. Verify that the first five messages of that conversation is shown with their respective senders in the statistics popup.
  • Test B
  1. Load sample data
  2. Click on a public conversation (group chat) and verify that the statistics popup for that conversation is opened
  3. Verify that the first five messages of that conversation is shown with their respective senders in the statistics popup.
  • Test C
  1. Load sample data
  2. Click on a conversation with less than 5 messages and verify that the statistics popup for that conversation is opened
  3. Verify that the first <5 messages of that conversation is shown with their respective senders in the statistics popup.

Test Configuration:

  • App version: 0.1.8
  • Hardware: MacBook Air 2022, M2 chip running Sonoma 14.3.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Kubis10 Kubis10 self-assigned this Apr 28, 2024
@Kubis10 Kubis10 self-requested a review April 28, 2024 20:23
@Kubis10
Copy link
Owner

Kubis10 commented Apr 29, 2024

Try to resolve conflicts first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better sorting
2 participants