Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RLP tests with authz #209

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Add RLP tests with authz #209

merged 1 commit into from
Nov 7, 2023

Conversation

jsmolar
Copy link
Contributor

@jsmolar jsmolar commented May 22, 2023

No description provided.

@jsmolar jsmolar marked this pull request as draft May 22, 2023 14:26
@jsmolar jsmolar force-pushed the rate_limit_auth branch 2 times, most recently from 5d2720e to 76d4199 Compare May 23, 2023 15:48
@jsmolar jsmolar marked this pull request as ready for review June 16, 2023 12:16
averevki
averevki reviewed Jun 20, 2023
View reviewed changes
testsuite/objects/sections.py Outdated Show resolved Hide resolved
testsuite/openshift/objects/auth_config/sections.py Outdated Show resolved Hide resolved
testsuite/tests/kuadrant/test_rate_limit_authz.py Outdated Show resolved Hide resolved
testsuite/tests/kuadrant/test_rate_limit_authz.py Outdated Show resolved Hide resolved
@pehala pehala marked this pull request as draft June 20, 2023 12:23
@jsmolar jsmolar marked this pull request as ready for review November 6, 2023 16:48
@pehala pehala changed the title Added configurations for RLP Add RLP tests with authz Nov 7, 2023
pehala
pehala previously approved these changes Nov 7, 2023
View reviewed changes
@jsmolar jsmolar requested a review from averevki November 7, 2023 09:45
averevki
averevki approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@averevki averevki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can suggest to squash commits 👍

testsuite/openshift/objects/rate_limit.py Outdated Show resolved Hide resolved
averevki
averevki previously approved these changes Nov 7, 2023
View reviewed changes
testsuite/tests/kuadrant/test_rate_limit_authz.py Outdated Show resolved Hide resolved
@jsmolar jsmolar dismissed stale reviews from averevki and pehala via b3aadc5 November 7, 2023 17:58
@pehala pehala merged commit a29bf81 into Kuadrant:main Nov 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mganisin mganisin mganisin left review comments

@averevki averevki averevki approved these changes

@pehala pehala pehala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsmolar @pehala @mganisin @averevki