Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm manifests template based #165

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Oct 3, 2024

What

Helm manifests do not contain a namespace object. It is all delegated to the helm tool.

Discussion on Kuadrant/authorino-operator#202

Additionally, added verify ci test to ensure chart manifests are up to date

Verification steps

Preparation setup

make kind-create-cluster

Install helm charts

make helm
bin/helm install limitador-operator ./charts/limitador-operator/ --namespace limitador-system --create-namespace

Check status

bin/helm status limitador-operator -n limitador-system

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (bd4757e) to head (e2cc561).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   84.17%   84.59%   +0.41%     
==========================================
  Files          18       18              
  Lines         967      967              
==========================================
+ Hits          814      818       +4     
+ Misses        101       99       -2     
+ Partials       52       50       -2     
Flag Coverage Δ
integration 78.80% <ø> (+0.82%) ⬆️
unit 65.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1alpha1 (u) 100.00% <ø> (ø)
pkg/helpers (u) 80.64% <ø> (ø)
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) 73.52% <ø> (ø)
pkg/limitador (u) 98.11% <ø> (ø)
controllers (i) 75.91% <ø> (+1.33%) ⬆️
pkg/upgrades ∅ <ø> (∅)

see 1 file with indirect coverage changes

@eguzki eguzki marked this pull request as ready for review October 3, 2024 15:59
@eguzki eguzki force-pushed the helm-manifest-templated-namespace branch from 1ad6c59 to e2cc561 Compare October 10, 2024 15:03
@eguzki eguzki merged commit d0d5323 into main Oct 10, 2024
17 checks passed
@eguzki eguzki deleted the helm-manifest-templated-namespace branch October 10, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants