-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add withData
#448
base: dev
Are you sure you want to change the base?
Add withData
#448
Conversation
* @param dataFrame The DataFrame to be used as a dataset within the scope. | ||
* @param block layer creator scope with a new dataset. | ||
*/ | ||
public inline fun <T> withData( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be reflected somehow in tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add tests later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, at this stage of the library development, we should write tests right away. This will help us catch bugs faster, verify the API if it’s a public one, and reduce issues in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Example:
|
@@ -11,7 +11,7 @@ dataframe = "0.14.1" | |||
serialization = "1.6.3" | |||
datetime = "0.6.0" | |||
html = "0.11.0" | |||
statistics = "0.3.1-dev-31" | |||
statistics = "0.4.0-dev-8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to separate our builds for release and dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approximately what is done in dataframe:
- For stable releases or for M, RC versions, we manually change the version and run a release publish on the build server
- For dev versions, we run publish with the dev flag (or explicitly differentiate between publish and dev publish), and a dev suffix with the build number is automatically added
This will eliminate the need for us to manually control dev versions
* @param dataFrame The DataFrame to be used as a dataset within the scope. | ||
* @param block layer creator scope with a new dataset. | ||
*/ | ||
public inline fun <T> withData( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, at this stage of the library development, we should write tests right away. This will help us catch bugs faster, verify the API if it’s a public one, and reduce issues in the future
Added tests & docs |
# Conflicts: # gradle/libs.versions.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Partially solves #430.
Add
withData {}
that allows to modify dataset for layers. SupportsDataFrame
extensions.