Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard-renderer): ResizeObserver on dashboard tiles #1291

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

filipgutica
Copy link
Contributor

@filipgutica filipgutica commented Mar 25, 2024

Summary

implement resize observer on dashboard tiles to notify analytics-chart of height updates when rows have tiles that are "fitToContent"

Resources

@filipgutica filipgutica requested a review from a team as a code owner March 25, 2024 16:19
@filipgutica filipgutica changed the title Fix/chart tiles resize observer fix(dashboard-renderer): ResizeObserver on dashboard tiles Mar 25, 2024
@filipgutica filipgutica force-pushed the fix/chart-tiles-resize-observer branch from 7252e10 to 05bc6a1 Compare March 25, 2024 16:25
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/dashboard-renderer@pr-1291

Copy link
Contributor

@adorack adorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a bit more time to think about failure states and possibly try it out in the sandbox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants