refacto: type filesystem and filesystem interface #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinArtus
force-pushed
the
refacto/type-filesystem
branch
2 times, most recently
from
1a4e105
to
4efd05c
Compare
KevinArtus
force-pushed
the
refacto/type-filesystem
branch
from
4efd05c
to
93de4a6
Compare
muchafm
suggested changes
Oct 30, 2023
PedroTroller
requested changes
Oct 30, 2023
| * @throws \InvalidArgumentException If $key is invalid | ||
| */ | ||
| public function createStream($key); | ||
| public function createStream(string $key): Stream|Stream\InMemoryBuffer; |
There was a problem hiding this comment.
Stream\InMemoryBuffer is a Stream.
PedroTroller
requested changes
Oct 30, 2023
src/Gaufrette/Filesystem.php
Outdated
| @@ -228,7 +223,7 @@ public function size($key) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function createStream($key) | |||
| public function createStream(string $key): Stream|Stream\InMemoryBuffer | |||
muchafm
approved these changes
Oct 30, 2023
PedroTroller
force-pushed
the
refacto/type-filesystem
branch
3 times, most recently
from
39af2b6
to
a80339a
Compare
PedroTroller
force-pushed
the
refacto/type-filesystem
branch
from
a80339a
to
506c9ab
Compare
PedroTroller
force-pushed
the
refacto/type-filesystem
branch
from
506c9ab
to
fce19cc
Compare
muchafm
approved these changes
Feb 26, 2024
PedroTroller
added a commit
that referenced
this pull request
Feb 26, 2024
* refacto: type filesystem and filesystem interface * fix review * fix return type createStream * refactor: fix php-cs-fixer error --------- Co-authored-by: PedroTroller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.