Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lmpl DropView #245

Merged
merged 2 commits into from
Nov 14, 2024
Merged

feat: lmpl DropView #245

merged 2 commits into from
Nov 14, 2024

Conversation

wszhdshys
Copy link
Contributor

@wszhdshys wszhdshys commented Nov 14, 2024 •
edited by KKould
Loading

What problem does this PR solve?

//

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Nov 14, 2024
@KKould KKould added the enhancement New feature or request label Nov 14, 2024
@KKould KKould assigned wszhdshys and unassigned KKould Nov 14, 2024
@KKould KKould self-requested a review November 14, 2024 10:34
loloxwg
loloxwg approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@loloxwg loloxwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@loloxwg loloxwg merged commit 6cfb28f into KipData:main Nov 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloxwg loloxwg loloxwg approved these changes

@KKould KKould Awaiting requested review from KKould

Assignees

@wszhdshys wszhdshys

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wszhdshys @loloxwg @KKould